netdev - Re: [PATCH net 03/24] crypto: Add 'krb5enc' hash and cipher AEAD algorithm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1934018.1739123634@warthog.procyon.org.uk>
Date: Sun, 09 Feb 2025 17:53:54 +0000
From: David Howells <dhowells@...hat.com>
To: Herbert Xu <herbert@...dor.apana.org.au>
Cc: dhowells@...hat.com, netdev@...r.kernel.org,
    Marc Dionne <marc.dionne@...istor.com>,
    Jakub Kicinski <kuba@...nel.org>,
    "David S. Miller" <davem@...emloft.net>,
    Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
    Simon Horman <horms@...nel.org>,
    Trond Myklebust <trond.myklebust@...merspace.com>,
    Chuck Lever <chuck.lever@...cle.com>,
    Eric Biggers <ebiggers@...nel.org>, Ard Biesheuvel <ardb@...nel.org>,
    linux-crypto@...r.kernel.org, linux-afs@...ts.infradead.org,
    linux-nfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 03/24] crypto: Add 'krb5enc' hash and cipher AEAD algorithm

Herbert Xu <herbert@...dor.apana.org.au> wrote:

> > [!] Note that the net/sunrpc/auth_gss/ implementation gets a pair of
> > ciphers, one non-CTS and one CTS, using the former to do all the aligned
> > blocks and the latter to do the last two blocks if they aren't also
> > aligned.  It may be necessary to do this here too for performance reasons -
> > but there are considerations both ways:
> 
> The CTS template will take any hardware accelerated CBC implementation
> and turn it into CTS.
> 
> So there is no reason to do the CTS/CBC thing by hand at all.

Glad to hear it.  I'm just reporting what net/sunrpc/ does now.  My suspicion
is that this is from before a lot of cpu crypto-based optimisations were made
available in the crypto layer.

David