netdev - Re: [PATCH 1/1] can: esd_usb: Fix not detecting version reply in probe routine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250209-dynamic-horse-of-defense-2e450f-mkl@pengutronix.de>
Date: Sun, 9 Feb 2025 20:40:28 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Stefan Mätje <Stefan.Maetje@....eu>
Cc: "horms@...nel.org" <horms@...nel.org>, 
	"linux-can@...r.kernel.org" <linux-can@...r.kernel.org>, Frank Jungclaus <frank.jungclaus@....eu>, 
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "mailhol.vincent@...adoo.fr" <mailhol.vincent@...adoo.fr>
Subject: Re: [PATCH 1/1] can: esd_usb: Fix not detecting version reply in
 probe routine

On 09.02.2025 18:53:43, Stefan Mätje wrote:
> > > > >  	if (err < 0) {
> > > > >  		dev_err(&intf->dev, "no version message answer\n");
> > > > > -		goto free_msg;
> > > > > +		goto free_buf;
> > > > >  	}
> > > > >  
> > > > > -	dev->net_count = (int)msg->version_reply.nets;
> > > > > -	dev->version = le32_to_cpu(msg->version_reply.version);
> > > > > -
> > > > >  	if (device_create_file(&intf->dev, &dev_attr_firmware))
> > > > >  		dev_err(&intf->dev,
> > > > >  			"Couldn't create device file for firmware\n");
> > > > > @@ -1332,11 +1392,12 @@ static int esd_usb_probe(struct usb_interface *intf,
> > > > >  	for (i = 0; i < dev->net_count; i++)
> > > > >  		esd_usb_probe_one_net(intf, i);
> > > 
> > > Return values are not checked here. :/
> 
> Yes, that is another flaw. This needs to be tackled in another patch.

ACK

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)