netdev - Re: [Patch v2 0/3] IB/core: Fix GID cache for bonded net devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250209094528.GB17863@unreal>
Date: Sun, 9 Feb 2025 11:45:28 +0200
From: Leon Romanovsky <leon@...nel.org>
To: longli@...uxonhyperv.com
Cc: Jason Gunthorpe <jgg@...pe.ca>, Ajay Sharma <sharmaajay@...rosoft.com>,
	Konstantin Taranov <kotaranov@...rosoft.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-hyperv@...r.kernel.org,
	Long Li <longli@...rosoft.com>
Subject: Re: [Patch v2 0/3] IB/core: Fix GID cache for bonded net devices

On Fri, Feb 07, 2025 at 01:36:15PM -0800, longli@...uxonhyperv.com wrote:
> From: Long Li <longli@...rosoft.com>
> 
> When populating GID cache for net devices in a bonded setup, it should use the master device's
> address whenever applicable.
> 
> The current code has some incorrect behaviors when dealing with bonded devices:
> 1. It adds IP of bonded slave to the GID cache when the device is already bonded
> 2. It adds IP of bonded slave to the GID cache when the device becomes bonded (via NETDEV_CHANGEUPPER notifier)
> 3. When a bonded slave device is unbonded, it doesn't add its IP to the default table in GID cache.

I took a look at the patches and would like to see the reasoning why
current behaviour is incorrect and need to be changed. In addition,
there is a need to add examples of what is "broken" now and will start
to work after the fixes.

Thanks


> 
> The patchset fixes those issues.
> 
> Changes log:
> v2: Added cover letter explaining the overall problem and current behaviors.
> 
> Long Li (3):
>   IB/core: Do not use netdev IP if it is a bonded slave
>   IB/core: Use upper_device_filter to add upper ips
>   IB/core: Add default IP when a slave is unlinked
> 
>  drivers/infiniband/core/roce_gid_mgmt.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)
> 
> -- 
> 2.34.1
>