netdev - Re: [PATCH net-next] net: sfp: add quirk for 2.5G OEM BX SFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z6jGL9oUs5DElOEg@makrotopia.org>
Date: Sun, 9 Feb 2025 15:13:51 +0000
From: Daniel Golle <daniel@...rotopia.org>
To: Birger Koblitz <mail@...ger-koblitz.de>
Cc: netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next] net: sfp: add quirk for 2.5G OEM BX SFP

On Sun, Feb 09, 2025 at 12:01:55PM +0100, Birger Koblitz wrote:
> The OEM SFP-2.5G-BX10-D/U SFP module pair is meant to operate with
> 2500Base-X. However, in their EEPROM they incorrectly specify:
> Transceiver codes   : 0x00 0x12 0x00 0x00 0x12 0x00 0x01 0x05 0x00
> BR, Nominal         : 2500MBd
> 
> Use sfp_quirk_2500basex for this module to allow 2500Base-X mode anyway.
> Run-tested on BananaPi R3.
> 
> Signed-off-by: Birger Koblitz <mail@...ger-koblitz.de>

Reviewed-by: Daniel Golle <daniel@...rotopia.org>

> ---
>  drivers/net/phy/sfp.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/phy/sfp.c b/drivers/net/phy/sfp.c
> index 7dbcbf0a4ee2..9369f5297769 100644
> --- a/drivers/net/phy/sfp.c
> +++ b/drivers/net/phy/sfp.c
> @@ -515,6 +515,8 @@ static const struct sfp_quirk sfp_quirks[] = {
>   	SFP_QUIRK_F("OEM", "SFP-10G-T", sfp_fixup_rollball_cc),
>  	SFP_QUIRK_M("OEM", "SFP-2.5G-T", sfp_quirk_oem_2_5g),
> +	SFP_QUIRK_M("OEM", "SFP-2.5G-BX10-D", sfp_quirk_2500basex),
> +	SFP_QUIRK_M("OEM", "SFP-2.5G-BX10-U", sfp_quirk_2500basex),
>  	SFP_QUIRK_F("OEM", "RTSFP-10", sfp_fixup_rollball_cc),
>  	SFP_QUIRK_F("OEM", "RTSFP-10G", sfp_fixup_rollball_cc),
>  	SFP_QUIRK_F("Turris", "RTSFP-2.5G", sfp_fixup_rollball),
> -- 
> 2.39.5