netdev - Re: [iwl-next,rdma v3 00/24] Add RDMA support for Intel IPU E2000 (GEN3)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7e12c97d-8733-44df-b80e-2956c0e59dae@intel.com>
Date: Mon, 10 Feb 2025 11:41:31 +0100
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Tatyana Nikolova <tatyana.e.nikolova@...el.com>, <jgg@...dia.com>,
	<leon@...nel.org>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>
CC: <linux-rdma@...r.kernel.org>, <netdev@...r.kernel.org>,
	<intel-wired-lan@...ts.osuosl.org>, Tony Nguyen <anthony.l.nguyen@...el.com>,
	Simon Horman <horms@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>, "Eric
 Dumazet" <edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>
Subject: Re: [iwl-next,rdma v3 00/24] Add RDMA support for Intel IPU E2000
 (GEN3)

On 2/7/25 20:49, Tatyana Nikolova wrote:
> This patch series is based on 6.14-rc1 and includes both netdev and RDMA
> patches for ease of review. It can also be viewed here [1]. A shared pull
> request will be sent for patches 1-7 following review.
> 

[...]
TLDR of my mail: could be take 1st patch prior to the rest?

> V2 RFC series is at https://lwn.net/Articles/987141/.

code there was mostly the same, and noone commented, I bet due
to the sheer size of the series

>   58 files changed, 6693 insertions(+), 1137 deletions(-)

While it is very good to have a common cover letter and all the changes
available for inspection/cross reference, it is just too much for doing
a practical review.

I think it would be much easier to follow and split into multiple series
if we will apply the first patch, is that feasible now? (It was a no-no
back when there were no idpf at all, no it is not a theoretical case
anymore, and the patch makes code better anyway)?

The first patch:
Dave Ertman (1):
   iidc/ice/irdma: Update IDC to support multiple consumers

@Tatyana
The rest of the patches needs to go via our internal e1000 ML,
and get the Reviewed-by tag prior to being ready for wider review
(now the community would have to put substantial effor to get rid
of style distractions, etc, and, as we have seen, there was not
much eagerness to do that for your RFC v2).