netdev - Re: [PATCH net-next 3/4] tcp: use EXPORT_IPV6_MOD[

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6nkddoL7RAHw-y5@hog>
Date: Mon, 10 Feb 2025 12:35:17 +0100
From: Sabrina Dubroca <sd@...asysnail.net>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, Willem de Bruijn <willemb@...gle.com>,
	Simon Horman <horms@...nel.org>, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 3/4] tcp: use EXPORT_IPV6_MOD[_GPL]()

2025-02-10, 10:56:22 +0100, Eric Dumazet wrote:
> On Mon, Feb 10, 2025 at 10:44 AM Eric Dumazet <edumazet@...gle.com> wrote:
> >
> > On Mon, Feb 10, 2025 at 10:30 AM Sabrina Dubroca <sd@...asysnail.net> wrote:
> > >
> > > 2025-02-10, 08:28:04 +0000, Eric Dumazet wrote:
> > > > @@ -613,7 +613,7 @@ __poll_t tcp_poll(struct file *file, struct socket *sock, poll_table *wait)
> > > >
> > > >       return mask;
> > > >  }
> > > > -EXPORT_SYMBOL(tcp_poll);
> > > > +EXPORT_IPV6_MOD(tcp_poll);
> > >
> > > ktls uses it directly (net/tls/tls_main.c):
> >
> >
> > Oh, right.
> >
> > >
> > > static __poll_t tls_sk_poll(struct file *file, struct socket *sock,
> > >                             struct poll_table_struct *wait)
> > > {
> > >         struct tls_sw_context_rx *ctx;
> > >         struct tls_context *tls_ctx;
> > >         struct sock *sk = sock->sk;
> > >         struct sk_psock *psock;
> > >         __poll_t mask = 0;
> > >         u8 shutdown;
> > >         int state;
> > >
> > >         mask = tcp_poll(file, sock, wait);
> > > [...]
> > > }
> > >
> > > If you want to un-export tcp_poll, I guess we'll need to add the same
> > > thing as for ->sk_data_ready (save the old ->poll to tls_context).
> >
> > No need, I simply missed tls was using tcp_poll() can could be a
> > module, I will fix in V2
> >
> 
> TLS also calls tcp_under_memory_pressure() via tcp_epollin_ready(),
> so tcp_memory_pressure needs to be exported as well.

Ah, yes, didn't think about inline helpers.

I ran a quick build since I was concerned about what the Chelsio TOE
driver might be using, but spotted this instead:

ERROR: modpost: "secure_tcpv6_seq" [drivers/infiniband/hw/irdma/irdma.ko] undefined!

-- 
Sabrina