[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d6c53cdc35c3706ee9b6cad8b60db88840975800.camel@codeconstruct.com.au>
Date: Mon, 10 Feb 2025 09:57:15 +0800
From: Jeremy Kerr <jk@...econstruct.com.au>
To: Simon Horman <horms@...nel.org>
Cc: Matt Johnston <matt@...econstruct.com.au>, Greg Kroah-Hartman
<gregkh@...uxfoundation.org>, Andrew Lunn <andrew+netdev@...n.ch>, "David
S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub
Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
netdev@...r.kernel.org, linux-usb@...r.kernel.org, Santosh Puranik
<spuranik@...dia.com>
Subject: Re: [PATCH net-next 2/2] net: mctp: Add MCTP USB transport driver
Hi Horms,
> > + skb->protocol = htons(ETH_P_MCTP);
> > + skb_reset_network_header(skb);
> > + cb = __mctp_cb(skb);
> > + cb->halen = 0;
> > + netif_rx(skb);
>
> Hi Jeremy,
>
> skb is dereferenced a few lines further down,
> but I don't think it is is safe to do so after calling netif_rx().
Yep, neither do I. I have moved the rx accounting prior to the
netif_rx() call for v2.
Thanks for the check!
Cheers,
Jeremy
Powered by blists - more mailing lists