netdev - Re: [PATCH net-next v3 0/3] net: dsa: add support for phylink managed EEE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250210132806.djzhqgemh4egiz2w@skbuf>
Date: Mon, 10 Feb 2025 15:28:06 +0200
From: Vladimir Oltean <olteanv@...il.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	"Chester A. Unal" <chester.a.unal@...nc9.com>,
	Daniel Golle <daniel@...rotopia.org>,
	"David S. Miller" <davem@...emloft.net>,
	DENG Qingfang <dqfext@...il.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>,
	linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org,
	Matthias Brugger <matthias.bgg@...il.com>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>, Sean Wang <sean.wang@...iatek.com>,
	Simon Horman <horms@...nel.org>
Subject: Re: [PATCH net-next v3 0/3] net: dsa: add support for phylink
 managed EEE

On Mon, Feb 10, 2025 at 10:36:42AM +0000, Russell King (Oracle) wrote:
> Hi,
> 
> This series adds support for phylink managed EEE to DSA, and converts
> mt753x to make use of this feature.
> 
> Patch 1 implements a helper to indicate whether the MAC LPI operations
> are populated (suggested by Vladimir)
> 
> Patch 2 makes the necessary changes to the core code - we retain calling
> set_mac_eee(), but this method now becomes a way to merely validate the
> arguments when using phylink managed EEE rather than performing any
> configuration.
> 
> Patch 3 converts the mt7530 driver to use phylink managed EEE.
> 
> v2: fix mt7530 build error
> v3: send correct patch 2
> 
>  drivers/net/dsa/mt7530.c  | 68 ++++++++++++++++++++++++++++++++---------------
>  drivers/net/phy/phylink.c |  3 +--
>  include/linux/phylink.h   | 12 +++++++++
>  net/dsa/user.c            | 21 +++++++++------
>  4 files changed, 73 insertions(+), 31 deletions(-)

Apart from the kernel-doc thing this looks fine to me. Please keep the
tags in patches if there is a need to resend.

Reviewed-by: Vladimir Oltean <olteanv@...il.com>