netdev - Re: [PATCH v2 net-next 4/4] sfc: document devlink flash support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <p527x74v7gycii3qfgcqn46j2dixpa62tguri6k2dzymohkeyw@rqqmgs5tbobj>
Date: Mon, 10 Feb 2025 14:51:59 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: edward.cree@....com
Cc: linux-net-drivers@....com, davem@...emloft.net, kuba@...nel.org, 
	edumazet@...gle.com, pabeni@...hat.com, horms@...nel.org, andrew+netdev@...n.ch, 
	Edward Cree <ecree.xilinx@...il.com>, habetsm.xilinx@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next 4/4] sfc: document devlink flash support

Mon, Feb 10, 2025 at 12:25:45PM +0100, edward.cree@....com wrote:
>From: Edward Cree <ecree.xilinx@...il.com>
>
>Update the information in sfc's devlink documentation including
> support for firmware update with devlink flash.
>Also update the help text for CONFIG_SFC_MTD, as it is no longer
> strictly required for firmware updates.
>
>Signed-off-by: Edward Cree <ecree.xilinx@...il.com>
>---
> Documentation/networking/devlink/sfc.rst | 16 +++++++++++++++-
> drivers/net/ethernet/sfc/Kconfig         |  5 +++--
> 2 files changed, 18 insertions(+), 3 deletions(-)
>
>diff --git a/Documentation/networking/devlink/sfc.rst b/Documentation/networking/devlink/sfc.rst
>index db64a1bd9733..0398d59ea184 100644
>--- a/Documentation/networking/devlink/sfc.rst
>+++ b/Documentation/networking/devlink/sfc.rst
>@@ -5,7 +5,7 @@ sfc devlink support
> ===================
> 
> This document describes the devlink features implemented by the ``sfc``
>-device driver for the ef100 device.
>+device driver for the ef10 and ef100 devices.
> 
> Info versions
> =============
>@@ -18,6 +18,10 @@ The ``sfc`` driver reports the following versions
>    * - Name
>      - Type
>      - Description
>+   * - ``fw.bundle_id``

Why "id"? It is the bundle version, isn't it. In that case just "bundle"
would be fine I guess...


>+     - stored
>+     - Version of the firmware "bundle" image that was last used to update
>+       multiple components.
>    * - ``fw.mgmt.suc``
>      - running
>      - For boards where the management function is split between multiple
>@@ -55,3 +59,13 @@ The ``sfc`` driver reports the following versions
>    * - ``fw.uefi``
>      - running
>      - UEFI driver version (No UNDI support).
>+
>+Flash Update
>+============
>+
>+The ``sfc`` driver implements support for flash update using the
>+``devlink-flash`` interface. It supports updating the device flash using a
>+combined flash image ("bundle") that contains multiple components (on ef10,
>+typically ``fw.mgmt``, ``fw.app``, ``fw.exprom`` and ``fw.uefi``).
>+
>+The driver does not support any overwrite mask flags.
>diff --git a/drivers/net/ethernet/sfc/Kconfig b/drivers/net/ethernet/sfc/Kconfig
>index 3eb55dcfa8a6..c4c43434f314 100644
>--- a/drivers/net/ethernet/sfc/Kconfig
>+++ b/drivers/net/ethernet/sfc/Kconfig
>@@ -38,8 +38,9 @@ config SFC_MTD
> 	default y
> 	help
> 	  This exposes the on-board flash and/or EEPROM as MTD devices
>-	  (e.g. /dev/mtd1).  This is required to update the firmware or
>-	  the boot configuration under Linux.
>+	  (e.g. /dev/mtd1).  This is required to update the boot
>+	  configuration under Linux, or use some older userland tools to
>+	  update the firmware.
> config SFC_MCDI_MON
> 	bool "Solarflare SFC9100-family hwmon support"
> 	depends on SFC && HWMON && !(SFC=y && HWMON=m)