netdev - Re: [PATCH net-next v7 1/5] net: move ARFS rmap management to core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <760e3977-9f83-431b-b29b-f8ad1609b462@intel.com>
Date: Mon, 10 Feb 2025 08:04:43 -0700
From: Ahmed Zaki <ahmed.zaki@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: <netdev@...r.kernel.org>, <intel-wired-lan@...ts.osuosl.org>,
	<andrew+netdev@...n.ch>, <edumazet@...gle.com>, <horms@...nel.org>,
	<pabeni@...hat.com>, <davem@...emloft.net>, <michael.chan@...adcom.com>,
	<tariqt@...dia.com>, <anthony.l.nguyen@...el.com>,
	<przemyslaw.kitszel@...el.com>, <jdamato@...tly.com>, <shayd@...dia.com>,
	<akpm@...ux-foundation.org>, <shayagr@...zon.com>,
	<kalesh-anakkur.purayil@...adcom.com>, David Arinzon <darinzon@...zon.com>
Subject: Re: [PATCH net-next v7 1/5] net: move ARFS rmap management to core

On 2025-02-06 7:29 p.m., Jakub Kicinski wrote:

> Speaking of which, why do the auto-removal in napi_disable()
> rather than netif_napi_del() ? We don't reinstall on napi_enable()
> and doing a disable() + enable() is fairly common during driver
> reconfig.
> 

The patch does not re-install the notifiers in napi_add either, they are 
installed in set_irq() :

napi_add_config()  -> napi_set_irq()  -> napi_enable()

so napi_disable or napi_del seemed both OK to me.

However, I moved notifier auto-removal to npi_del() and did some testing 
on ice but it seems the driver does not delete napi on "ip link down" 
and that generates warnings on free_irq(). It only disables the napis.

So is this a bug? Do we need to ask drivers to disable __and__ delete 
napis before freeing the IRQs?

If not, then we have to keep notifier aut-removal in napi_diasable().