netdev - Re: [PATCH v2 net-next 4/4] sfc: document devlink flash support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <jdcpuvjqoa3ous73eb5m3f3xartbrasrmwbyefnrwjrscmmrs2@nzalfdm4zd5y>
Date: Mon, 10 Feb 2025 17:21:24 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Edward Cree <ecree.xilinx@...il.com>
Cc: linux-net-drivers@....com, davem@...emloft.net, kuba@...nel.org, 
	edumazet@...gle.com, pabeni@...hat.com, horms@...nel.org, andrew+netdev@...n.ch, 
	habetsm.xilinx@...il.com, netdev@...r.kernel.org, edward.cree@....com, 
	Jacob Keller <jacob.e.keller@...el.com>
Subject: Re: [PATCH v2 net-next 4/4] sfc: document devlink flash support

Mon, Feb 10, 2025 at 03:50:18PM +0100, ecree.xilinx@...il.com wrote:
>On 10/02/2025 13:51, Jiri Pirko wrote:
>> Mon, Feb 10, 2025 at 12:25:45PM +0100, edward.cree@....com wrote:
>>> Info versions
>>> =============
>>> @@ -18,6 +18,10 @@ The ``sfc`` driver reports the following versions
>>>    * - Name
>>>      - Type
>>>      - Description
>>> +   * - ``fw.bundle_id``
>> 
>> Why "id"? It is the bundle version, isn't it. In that case just "bundle"
>> would be fine I guess...
>
>bundle_id comes from DEVLINK_INFO_VERSION_GENERIC_FW_BUNDLE_ID in
> include/net/devlink.h, which git blame tells me was added by Jacob
> Keller in 2020 as a generalisation of a similar name in nfp.[1]
>Its use in sfc was added[2] by Alejandro Lucero in 2023 but seems to
> have been left out of the documentation at that time.
>The present patch series is merely documenting the name that already
> exists, not adding it.  Changing it might break existing scripts, and
> in any case would affect more drivers than just sfc (it is used by
> i40e, ice, and nfp).

Yeah, correct. I just found out myself by accident.

Thanks!


>
>CCing Jacob in case he has anything to add on why that name was chosen.
>
>[1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c90977a3c227
>[2]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=14743ddd2495