netdev - Re: [net-next PATCH v5 2/6] octeontx2-pf: Add AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250210164128.GG554665@kernel.org>
Date: Mon, 10 Feb 2025 16:41:28 +0000
From: Simon Horman <horms@...nel.org>
To: Suman Ghosh <sumang@...vell.com>
Cc: sgoutham@...vell.com, gakula@...vell.com, sbhatta@...vell.com,
	hkelam@...vell.com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, lcherian@...vell.com,
	jerinj@...vell.com, john.fastabend@...il.com, bbhushan2@...vell.com,
	hawk@...nel.org, andrew+netdev@...n.ch, ast@...nel.org,
	daniel@...earbox.net, bpf@...r.kernel.org, larysa.zaremba@...el.com
Subject: Re: [net-next PATCH v5 2/6] octeontx2-pf: Add AF_XDP non-zero copy
 support

On Thu, Feb 06, 2025 at 02:20:30PM +0530, Suman Ghosh wrote:
> Set xdp rx ring memory type as MEM_TYPE_PAGE_POOL for
> af-xdp to work. This is needed since xdp_return_frame
> internally will use page pools.
> 
> Fixes: 06059a1a9a4a ("octeontx2-pf: Add XDP support to netdev PF")
> Signed-off-by: Suman Ghosh <sumang@...vell.com>

Hi Suman,

If this is a bug fix then it should be targeted at net, which
implies splitting it out of this patch-set.

If, on the other hand, it is not a fix then it should not have a Fixes tag.
In that case you can cite a commit using this syntax:

commit 06059a1a9a4a ("octeontx2-pf: Add XDP support to netdev PF")

Unlike a Fixes tag it:
* Should be in the body of the patch description,
  rather than part of the tags at the bottom of the patch description
* May be line wrapped
* Can me included in a sentence