netdev - Re: [PATCH net] net: phylink: make configuring clock-stop dependent on MAC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5232a50c-3840-4c76-8b9b-cb0dcbbcc833@lunn.ch>
Date: Mon, 10 Feb 2025 01:32:42 +0100
From: Andrew Lunn <andrew@...n.ch>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Jacob Keller <jacob.e.keller@...el.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net] net: phylink: make configuring clock-stop dependent
 on MAC support

On Sat, Feb 08, 2025 at 11:52:23AM +0000, Russell King (Oracle) wrote:
> We should not be configuring the PHYs clock-stop settings unless the
> MAC supports phylink managed EEE. Make this dependent on MAC support.
> 
> This was noticed in a suspicious RCU usage report from the kernel
> test robot (the suspicious RCU usage due to calling phy_detach()
> remains unaddressed, but is triggered by the error this was
> generating.)
> 
> Fixes: 03abf2a7c654 ("net: phylink: add EEE management")
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew