netdev - Re: [RFC PATCH v1 net-next] net: mlxsw_sp: Use switchdev_handle_port_obj_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6mhQL-b58L5xkK4@shredder>
Date: Mon, 10 Feb 2025 08:48:32 +0200
From: Ido Schimmel <idosch@...dia.com>
To: Eric Woudstra <ericwouds@...il.com>
Cc: Petr Machata <petrm@...dia.com>, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Vladimir Oltean <olteanv@...il.com>,
	Nikolay Aleksandrov <razor@...ckwall.org>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v1 net-next] net: mlxsw_sp: Use
 switchdev_handle_port_obj_add_foreign() for vxlan

On Sat, Feb 08, 2025 at 03:15:18PM +0100, Eric Woudstra wrote:
> Sending as RFC as I do not own this hardware. This code is not tested.
> 
> Vladimir found this part of the spectrum switchdev, while looking at
> another issue here:
> 
> https://lore.kernel.org/all/20250207220408.zipucrmm2yafj4wu@skbuf/
> 
> As vxlan seems a foreign port, wouldn't it be better to use
> switchdev_handle_port_obj_add_foreign() ?

Thanks for the patch, but the VXLAN port is not foreign to the other
switch ports. That is, forwarding between these ports and VXLAN happens
in hardware. And yes, switchdev_bridge_port_offload() does need to be
called for the VXLAN port so that it's assigned the same hardware domain
as the other ports.