netdev - Re: [PATCH net-next 4/5] tcp: add the ability to control max RTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL+tcoCGz-3_ThpEfHSBn6U8oAYwVY1OZ0FRwOGT_fSNDYio2A@mail.gmail.com>
Date: Mon, 10 Feb 2025 16:28:47 +0800
From: Jason Xing <kerneljasonxing@...il.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	Neal Cardwell <ncardwell@...gle.com>, Kuniyuki Iwashima <kuniyu@...zon.com>, 
	Jason Xing <kernelxing@...cent.com>, Simon Horman <horms@...nel.org>, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 4/5] tcp: add the ability to control max RTO

On Mon, Feb 10, 2025 at 4:18 PM Eric Dumazet <edumazet@...gle.com> wrote:
>
> On Sat, Feb 8, 2025 at 6:37 AM Jason Xing <kerneljasonxing@...il.com> wrote:
> >
> > On Fri, Feb 7, 2025 at 11:31 PM Eric Dumazet <edumazet@...gle.com> wrote:
> > >
> > > Currently, TCP stack uses a constant (120 seconds)
> > > to limit the RTO value exponential growth.
> > >
> > > Some applications want to set a lower value.
> > >
> > > Add TCP_RTO_MAX_MS socket option to set a value (in ms)
> > > between 1 and 120 seconds.
> > >
> > > It is discouraged to change the socket rto max on a live
> > > socket, as it might lead to unexpected disconnects.
> > >
> > > Following patch is adding a netns sysctl to control the
> > > default value at socket creation time.
> >
> > I assume a bpf extension could be considered as a follow up patch on
> > top of the series?
>
> I left BPF and MPTP follow ups being handled by their owners

Good to know that. I will complete the BPF extension as soon as your
series gets merged.

Thanks,
Jason