netdev - Re: [PATCH net-next 3/4] tcp: use EXPORT_IPV6_MOD[

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <31325da6-d74b-4c9c-ada8-67100bd50310@intel.com>
Date: Mon, 10 Feb 2025 09:41:10 +0100
From: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
To: Eric Dumazet <edumazet@...gle.com>, "David S . Miller"
	<davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>
CC: <netdev@...r.kernel.org>, Willem de Bruijn <willemb@...gle.com>, "Simon
 Horman" <horms@...nel.org>, <eric.dumazet@...il.com>
Subject: Re: [PATCH net-next 3/4] tcp: use EXPORT_IPV6_MOD[_GPL]()



On 2/10/2025 9:28 AM, Eric Dumazet wrote:
> Use EXPORT_IPV6_MOD[_GPL]() for symbols that don't need
> to be exported unless CONFIG_IPV6=m
> 
> tcp_hashinfo is no longer used from any module anyway.

You also removed EXPORT for tcp_openreq_init_rwin function. Quick
grep shows that it is also not used anymore by any module, so probably
you forgot to add this info to commit message? Do you think it is worth
to add?

> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> ---

[...]

> @@ -457,7 +457,6 @@ void tcp_openreq_init_rwin(struct request_sock *req,
>   		rcv_wnd);
>   	ireq->rcv_wscale = rcv_wscale;
>   }
> -EXPORT_SYMBOL(tcp_openreq_init_rwin);

Exactly here