netdev - Re: [PATCH net-next 4/4] udp: use EXPORT_IPV6_MOD[

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iKh1xww10fQtcZEWBdOCYTxX98eMPOZ_5guBtYwwZvduw@mail.gmail.com>
Date: Tue, 11 Feb 2025 09:08:54 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: "David S . Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, 
	Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	Willem de Bruijn <willemb@...gle.com>, Simon Horman <horms@...nel.org>, eric.dumazet@...il.com
Subject: Re: [PATCH net-next 4/4] udp: use EXPORT_IPV6_MOD[_GPL]()

On Tue, Feb 11, 2025 at 3:56 AM Willem de Bruijn
<willemdebruijn.kernel@...il.com> wrote:
>
> Eric Dumazet wrote:
> > Use EXPORT_IPV6_MOD[_GPL]() for symbols that don't need
> > to be exported unless CONFIG_IPV6=m
> >
> > udp_table is no longer used from any modules, and does not
> > need to be exported anyway.
> >
> > Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>
> Should udp_disconnect be included?

Yes, it can.

>
> And perhaps udp_encap_needed_key. The only real user is static inline
> udp_unexpected_gso, itself only used in core udp code. But not sure if
> it would cause build errors.
>

udp_encap_needed_key and udpv6_encap_needed_key can both get the new
macro, thanks

> With those minor asides
>
> Acked-by: Willem de Bruijn <willemb@...gle.com>

I will squash the following in v2, thanks !

diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index 73ac614beb109146c5635aeeb10c2e9f77a6ee1c..3485989cd4bdec96e8cb7ecb28b68a25c3444a96
100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -808,11 +808,11 @@ static inline bool __udp_is_mcast_sock(struct
net *net, const struct sock *sk,
 }

 DEFINE_STATIC_KEY_FALSE(udp_encap_needed_key);
-EXPORT_SYMBOL(udp_encap_needed_key);
+EXPORT_IPV6_MOD(udp_encap_needed_key);

 #if IS_ENABLED(CONFIG_IPV6)
 DEFINE_STATIC_KEY_FALSE(udpv6_encap_needed_key);
-EXPORT_SYMBOL(udpv6_encap_needed_key);
+EXPORT_IPV6_MOD(udpv6_encap_needed_key);
 #endif

 void udp_encap_enable(void)
@@ -2185,7 +2185,7 @@ int udp_disconnect(struct sock *sk, int flags)
        release_sock(sk);
        return 0;
 }
-EXPORT_SYMBOL(udp_disconnect);
+EXPORT_IPV6_MOD(udp_disconnect);

 void udp_lib_unhash(struct sock *sk)
 {