netdev - RE: [Intel-wired-lan] [PATCH iwl-next v4] ixgbe: Fix possible skb NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BYAPR11MB35424D6905FF28058683DC7CF9FD2@BYAPR11MB3542.namprd11.prod.outlook.com>
Date: Tue, 11 Feb 2025 09:36:06 +0000
From: "Sanigani, SarithaX" <sarithax.sanigani@...el.com>
To: "Kwapulinski, Piotr" <piotr.kwapulinski@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"dan.carpenter@...aro.org" <dan.carpenter@...aro.org>,
	"yuehaibing@...wei.com" <yuehaibing@...wei.com>, "Fijalkowski, Maciej"
	<maciej.fijalkowski@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v4] ixgbe: Fix possible skb
 NULL pointer dereference

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Kwapulinski, Piotr
> Sent: 31 January 2025 17:45
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; dan.carpenter@...aro.org;
> yuehaibing@...wei.com; Fijalkowski, Maciej <maciej.fijalkowski@...el.com>;
> Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>; Kwapulinski, Piotr
> <piotr.kwapulinski@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v4] ixgbe: Fix possible skb NULL
> pointer dereference
> 
> The commit c824125cbb18 ("ixgbe: Fix passing 0 to ERR_PTR in
> ixgbe_run_xdp()") stopped utilizing the ERR-like macros for xdp status
> encoding. Propagate this logic to the ixgbe_put_rx_buffer().
> 
> The commit also relaxed the skb NULL pointer check - caught by Smatch.
> Restore this check.
> 
> Fixes: c824125cbb18 ("ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()")
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Acked-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> Signed-off-by: Piotr Kwapulinski <piotr.kwapulinski@...el.com>
> ---
> v1 -> v2
>   Provide extra details in commit message for motivation of this patch
> v2 -> v3
>   Simplify the check condition
> v3 -> v4
>   Rebase to net-queue
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Tested-by: Saritha Sanigani <sarithax.sanigani@...el.com> (A Contingent Worker at Intel)