netdev - RE: [Intel-wired-lan] [PATCH iwl-next v3] ixgbe: add support for thermal sensor event reception

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DS0PR11MB77856580F83D80DE883C82F0F0FD2@DS0PR11MB7785.namprd11.prod.outlook.com>
Date: Tue, 11 Feb 2025 10:03:30 +0000
From: "Jagielski, Jedrzej" <jedrzej.jagielski@...el.com>
To: Andrew Lunn <andrew@...n.ch>, Paul Menzel <pmenzel@...gen.mpg.de>
CC: "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Nguyen, Anthony L" <anthony.l.nguyen@...el.com>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, Simon Horman <horms@...nel.org>, "Kitszel,
 Przemyslaw" <przemyslaw.kitszel@...el.com>, "Polchlopek, Mateusz"
	<mateusz.polchlopek@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v3] ixgbe: add support for
 thermal sensor event reception

From: Andrew Lunn <andrew@...n.ch> 
Sent: Monday, February 10, 2025 2:37 PM
>> > > > Then driver
>> > > > logs appropriate message and closes the adapter instance.
>> > > > The card remains in that state until the platform is rebooted.
>> > > 
>> > > As a user I’d be interested what the threshold is, and what the measured
>> > > temperature is. Currently, the log seems to be just generic?
>> > 
>> > These details are FW internals.
>> > Driver just gets info that such event has happened.
>> > There's no additional information.
>> > 
>> > In that case driver's job is just to inform user that such scenario
>> > has happened and tell what should be the next steps.
>> 
>> From a user perspective that is a suboptimal behavior, and shows another
>> time that the Linux kernel should have all the control, and stuff like this
>> should be moved *out* of the firmware and not into the firmware.
>
>The older generations of hardware driven by this driver actually have
>HWMON support for the temperature sensor. I can understand the
>hardware protecting itself, and shutting down, but i agree with you,
>all the infrastructure already exists to report the temperature so why
>drop it? That actually seems like more work, and makes the device less
>friendly.


Actually there is only one adapter across all portfolio of ixgbe adapters
which supports this feature. That is 82599, none other supports it.
Even next generations (x540, x550) didn't provide support for reading thermal
data sensor.
As E610 is some type of extending x550 it also follows this path at this point.

Thanks
Jedrek