netdev - Re: [PATCH net-next v4 10/10] netlink: specs: wireless: add a spec for nl80211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAf2ycnV42g0YHMU9Jdv47J-5p44m2bgj6rjkpxBnXUUrWROzw@mail.gmail.com>
Date: Tue, 11 Feb 2025 11:15:17 +0000
From: Donald Hunter <donald.hunter@...hat.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Donald Hunter <donald.hunter@...il.com>, netdev@...r.kernel.org, 
	Jakub Kicinski <kuba@...nel.org>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Simon Horman <horms@...nel.org>, 
	Johannes Berg <johannes@...solutions.net>, linux-wireless@...r.kernel.org
Subject: Re: [PATCH net-next v4 10/10] netlink: specs: wireless: add a spec
 for nl80211

On Tue, 11 Feb 2025 at 10:59, Paolo Abeni <pabeni@...hat.com> wrote:
>
> On 2/7/25 1:15 PM, Donald Hunter wrote:
> > +        type: binary
> > +  -
> > +    name: nl80211-iftype-attrs
>
> I'm unsure if a respin is worth, but the above yields a strange looking
> c-struct name in generated/nl80211-user.h:
>
> struct nl80211_nl80211_iftype_attrs { //...
>
> All the cross-references looks correct, but replacing the above with:
>
> name: iftype-attrs
>
> AFAICS will also generate correct cross-reference and a more usual:
>
> struct nl80211_iftype_attrs { // ...

Yes, well spotted. I'll spin a v5. I've been making the same comment
on other reviews so I definitely need to heed the same advice.

> Also waiting for some explicit ack from wireless.
>
> Cheers,
>
> Paolo
>