netdev - Re: [PATCH net-next v3 02/14] docs: networking: Add PPE driver documentation for Qualcomm IPQ9574 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <387fbaa0-4210-4e75-aa15-003866c7735f@quicinc.com>
Date: Tue, 11 Feb 2025 20:36:33 +0800
From: Lei Wei <quic_leiwei@...cinc.com>
To: Bagas Sanjaya <bagasdotme@...il.com>, Luo Jie <quic_luoj@...cinc.com>,
        Andrew Lunn <andrew+netdev@...n.ch>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        "Paolo
 Abeni" <pabeni@...hat.com>, Rob Herring <robh@...nel.org>,
        Krzysztof
 Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Suruchi
 Agarwal <quic_suruchia@...cinc.com>,
        Pavithra R <quic_pavir@...cinc.com>, "Simon Horman" <horms@...nel.org>,
        Jonathan Corbet <corbet@....net>, Kees
 Cook <kees@...nel.org>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        "Philipp Zabel" <p.zabel@...gutronix.de>
CC: <linux-arm-msm@...r.kernel.org>, <netdev@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-doc@...r.kernel.org>, <linux-hardening@...r.kernel.org>,
        <quic_kkumarcs@...cinc.com>, <quic_linchen@...cinc.com>,
        <srinivas.kandagatla@...aro.org>, <bartosz.golaszewski@...aro.org>,
        <john@...ozen.org>
Subject: Re: [PATCH net-next v3 02/14] docs: networking: Add PPE driver
 documentation for Qualcomm IPQ9574 SoC



On 2/10/2025 10:15 AM, Bagas Sanjaya wrote:
> On Sun, Feb 09, 2025 at 10:29:36PM +0800, Luo Jie wrote:
>> +The Ethernet functionality in the PPE (Packet Process Engine) is comprised of three
>> +components: the switch core, port wrapper and Ethernet DMA.
>> +
>> +The Switch core in the IPQ9574 PPE has maximum of 6 front panel ports and two FIFO
>> +interfaces. One of the two FIFO interfaces is used for Ethernet port to host CPU
>> +communication using Ethernet DMA. The other is used communicating to the EIP engine
>                                      "The other one is used ..."

OK, I will fix here in next update.

>> +which is used for IPsec offload. On the IPQ9574, the PPE includes 6 GMAC/XGMACs that
>> +can be connected with external Ethernet PHY. Switch core also includes BM (Buffer
>> +Management), QM (Queue Management) and SCH (Scheduler) modules for supporting the
>> +packet processing.
>> +
>> <snipped>...
>> +The PPE driver files in drivers/net/ethernet/qualcomm/ppe/ are listed as below:
>> +
>> +- Makefile
>> +- ppe.c
>> +- ppe.h
>> +- ppe_config.c
>> +- ppe_config.h
>> +- ppe_debugfs.c
>> +- ppe_debugfs.h
>> +- ppe_regs.h
> 
> If somehow new source files were added, should the list above be updated to
> keep up?
> 

Yes, the list will be updated when new files added in the following PPE 
MAC and EDMA patch series.

>> +Enabling the Driver
>> +===================
>> +
>> +The driver is located in the menu structure at:
>> +
>> +  -> Device Drivers
>> +    -> Network device support (NETDEVICES [=y])
>> +      -> Ethernet driver support
>> +        -> Qualcomm devices
>> +          -> Qualcomm Technologies, Inc. PPE Ethernet support
> 
> Literal code block should format above nicer, but plain paragraph is fine.
> 

OK, I will use Literal code block by using "at::" to replace "at:" here. 
hope it is fine.

>> +
>> +If this driver is built as a module, we can use below commands to install and remove it:
>> +
>> +- insmod qcom-ppe.ko
>> +- rmmod qcom-ppe.ko
> 
> "If the driver is built as a module, the module will be called qcom-ppe."
> (I assume that readers know how to insert/remove modules).
> 

OK, I will modify this sentence in next update.

> Thanks.
>