netdev - Re: [PATCH net-next v3 06/14] net: ethernet: qualcomm: Initialize the PPE scheduler settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f8d30195-1ee9-42f2-be82-819c7f7bd219@lunn.ch>
Date: Tue, 11 Feb 2025 14:32:07 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Luo Jie <quic_luoj@...cinc.com>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Lei Wei <quic_leiwei@...cinc.com>,
	Suruchi Agarwal <quic_suruchia@...cinc.com>,
	Pavithra R <quic_pavir@...cinc.com>,
	Simon Horman <horms@...nel.org>, Jonathan Corbet <corbet@....net>,
	Kees Cook <kees@...nel.org>,
	"Gustavo A. R. Silva" <gustavoars@...nel.org>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	linux-arm-msm@...r.kernel.org, netdev@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-hardening@...r.kernel.org,
	quic_kkumarcs@...cinc.com, quic_linchen@...cinc.com,
	srinivas.kandagatla@...aro.org, bartosz.golaszewski@...aro.org,
	john@...ozen.org
Subject: Re: [PATCH net-next v3 06/14] net: ethernet: qualcomm: Initialize
 the PPE scheduler settings

> +/* Scheduler configuration for the assigning and releasing buffers for the
> + * packet passing through PPE, which is different per SoC.
> + */
> +static const struct ppe_scheduler_bm_config ipq9574_ppe_sch_bm_config[] = {
> +	{1, 0, 0, 0, 0},
> +	{1, 1, 0, 0, 0},
> +	{1, 0, 5, 0, 0},
> +	{1, 1, 5, 0, 0},
> +	{1, 0, 6, 0, 0},
> +	{1, 1, 6, 0, 0},
> +	{1, 0, 1, 0, 0},
> +	{1, 1, 1, 0, 0},

Rather than add a comment what it is, add a comment what it means.

It also looks like the first, 3 and 4 value are fixed, so do they even
need to be in the table? And the second value flip-flops?

	Andrew