netdev - Re: [PATCH] blackhole_dev: convert self-test to KUnit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJ-ks9mpqHc_m1VCiBkjgONjJGUVJRWqKUQziA1STfOvUFTqjQ@mail.gmail.com>
Date: Tue, 11 Feb 2025 10:32:31 -0500
From: Tamir Duberstein <tamird@...il.com>
To: Simon Horman <horms@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Shuah Khan <shuah@...nel.org>, Nathan Chancellor <nathan@...nel.org>, 
	Nick Desaulniers <ndesaulniers@...gle.com>, Bill Wendling <morbo@...gle.com>, 
	Justin Stitt <justinstitt@...gle.com>, linux-kernel@...r.kernel.org, 
	netdev@...r.kernel.org, linux-kselftest@...r.kernel.org, llvm@...ts.linux.dev, 
	Kees Cook <kees@...nel.org>
Subject: Re: [PATCH] blackhole_dev: convert self-test to KUnit

On Tue, Feb 11, 2025 at 9:47 AM Simon Horman <horms@...nel.org> wrote:
>
> On Fri, Feb 07, 2025 at 06:38:41PM -0500, Tamir Duberstein wrote:
> > Convert this very simple smoke test to a KUnit test.
>
> Hi Tamir,
>
> I think some text explaining why this change is being made is
> warranted here.

Hi Simon, I think that would be stating KUnit's raison d'etre? I
followed Kees' lead as seen in
https://lore.kernel.org/all/20240612195921.2685842-2-kees@kernel.org/.

In this case we saw the benefit right away: kernel test robot
immediately spotted and reported a bug which I fixed in v2:
https://lore.kernel.org/all/20250208-blackholedev-kunit-convert-v2-1-182db9bd56ec@gmail.com/.
Weirdly this message is absent from lore, but should be in your inbox
(and my reply to it *is* present on lore).

> >
> > Signed-off-by: Tamir Duberstein <tamird@...il.com>
> > ---
> > I tested this using:
> >
> > $ tools/testing/kunit/kunit.py run --arch arm64 --make_options LLVM=1 --kconfig_add CONFIG_NET=y blackholedev
>
> ...