netdev - Re: [PATCH v4 10/10] bnxt: Create an auxiliary device for fwctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a74484b3-9f69-45ef-a040-a46fbc2607d6@kernel.org>
Date: Tue, 11 Feb 2025 09:24:35 -0700
From: David Ahern <dsahern@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>, Jason Gunthorpe <jgg@...dia.com>
Cc: Saeed Mahameed <saeedm@...dia.com>,
 Andy Gospodarek <andrew.gospodarek@...adcom.com>,
 Aron Silverton <aron.silverton@...cle.com>,
 Dan Williams <dan.j.williams@...el.com>,
 Daniel Vetter <daniel.vetter@...ll.ch>, Dave Jiang <dave.jiang@...el.com>,
 Andy Gospodarek <gospo@...adcom.com>, Christoph Hellwig <hch@...radead.org>,
 Itay Avraham <itayavr@...dia.com>, Jiri Pirko <jiri@...dia.com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>,
 Leonid Bloch <lbloch@...dia.com>, Leon Romanovsky <leonro@...dia.com>,
 linux-cxl@...r.kernel.org, linux-rdma@...r.kernel.org,
 netdev@...r.kernel.org, "Nelson, Shannon" <shannon.nelson@....com>,
 Michael Chan <michael.chan@...adcom.com>
Subject: Re: [PATCH v4 10/10] bnxt: Create an auxiliary device for fwctl_bnxt

On 2/10/25 6:04 PM, Jakub Kicinski wrote:
> Yes, when RDMA driver is not loaded there should be no access to fwctl.
> When RDMA is disabled on the device via devlink there should be no
> fwctl access.
> 
> To disincentivize "creative workarounds" we have to also agree and
> document that fwctl must not be used to configure TCP/IP functions
> of the device, or host queues used by the netdev stack.

Your request is not about "RDMA only" since there are non-RDMA use cases
at play (e.g., CXL). It seems like what you are really asking for is a
hard exception for "netdev" use cases, right? So a summary along the
lines of:

"Any resources in use by the netdev stack can only be created and
modified by established netdev tools."