netdev - Re: [PATCH net-next 0/4] eth: mlx4: use the page pool for Rx buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250211105001.73b220fb@kernel.org>
Date: Tue, 11 Feb 2025 10:50:01 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Tariq Toukan <ttoukan.linux@...il.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, andrew+netdev@...n.ch, horms@...nel.org,
 tariqt@...dia.com, hawk@...nel.org
Subject: Re: [PATCH net-next 0/4] eth: mlx4: use the page pool for Rx
 buffers

On Tue, 11 Feb 2025 20:05:01 +0200 Tariq Toukan wrote:
> On 06/02/2025 17:58, Jakub Kicinski wrote:
> > On Thu, 6 Feb 2025 14:57:59 +0200 Tariq Toukan wrote:  
> >> Thanks for your patches.
> >>
> >> As this series touches critical data-path area, and you had no real
> >> option of testing it, we are taking it through a regression cycle, in
> >> parallel to the code review.
> >>
> >> We should have results early next week. We'll update.  
> > 
> > Sounds good, could you repost once ready?
> > I'll mark it as awaiting upstream in patchwork for now.
> > And feel free to drop the line pointed out by Ido, no real
> > preference either way there.  
> 
> Hi,
> 
> Patches passed functional tests.
> 
> Overall, the patches look good.

Thanks!

> Only a few comments:
> 1. Nit by Ido.
> 2. pool size.
> 3. xdp xmit support description.
> 
> How do you want to proceed?
> Do you want to fix and re-spin?

Sure thing, will do.