netdev - Re: [PATCH net-next 5/5] eth: fbnic: re-sort the objects in the Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6uq_f7knvHIhFT_@LQ3V64L9R2>
Date: Tue, 11 Feb 2025 11:54:37 -0800
From: Joe Damato <jdamato@...tly.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, alexanderduyck@...com, netdev@...r.kernel.org,
	edumazet@...gle.com, pabeni@...hat.com, andrew+netdev@...n.ch,
	horms@...nel.org
Subject: Re: [PATCH net-next 5/5] eth: fbnic: re-sort the objects in the
 Makefile

On Tue, Feb 11, 2025 at 10:13:56AM -0800, Jakub Kicinski wrote:
> Looks like recent commit broke the sort order, fix it.
> 
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
>  drivers/net/ethernet/meta/fbnic/Makefile | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/meta/fbnic/Makefile b/drivers/net/ethernet/meta/fbnic/Makefile
> index 239b2258ec65..0dbc634adb4b 100644
> --- a/drivers/net/ethernet/meta/fbnic/Makefile
> +++ b/drivers/net/ethernet/meta/fbnic/Makefile
> @@ -20,6 +20,7 @@ fbnic-y := fbnic_csr.o \
>  	   fbnic_pci.o \
>  	   fbnic_phylink.o \
>  	   fbnic_rpc.o \
> +	   fbnic_time.o \
>  	   fbnic_tlv.o \
>  	   fbnic_txrx.o \
> -	   fbnic_time.o
> +# End of objects

Incredibly minor nit, do you want to remove the trailing '\' after
fbnic_txrx.o which is the new last line to keep the format
consistent with how it was previously?

Your call, but I definitely feel bad pointing that out and
potentially causing a re-spin, so:

Acked-by: Joe Damato <jdamato@...tly.com>