netdev - Re: [PATCH net-next] ixgene-v2: prepare for phylib stop exporting phy_10_100_features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a8ad7d9b-4276-42e0-9dce-8a8b2115151c@gmail.com>
Date: Tue, 11 Feb 2025 22:57:51 +0100
From: Heiner Kallweit <hkallweit1@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, David Miller <davem@...emloft.net>,
 Andrew Lunn <andrew+netdev@...n.ch>, Simon Horman <horms@...nel.org>,
 Iyappan Subramanian <iyappan@...amperecomputing.com>,
 Keyur Chudgar <keyur@...amperecomputing.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] ixgene-v2: prepare for phylib stop exporting
 phy_10_100_features_array

On 11.02.2025 22:24, Andrew Lunn wrote:
>> +	linkmode_clear_bit(ETHTOOL_LINK_MODE_10baseT_Full_BIT,
>> +			   phydev->supported);
>> +	linkmode_clear_bit(ETHTOOL_LINK_MODE_10baseT_Half_BIT,
>> +			   phydev->supported);
>> +	linkmode_clear_bit(ETHTOOL_LINK_MODE_100baseT_Full_BIT,
>> +			   phydev->supported);
>> +	linkmode_clear_bit(ETHTOOL_LINK_MODE_100baseT_Half_BIT,
>> +			   phydev->supported);
>> +	linkmode_clear_bit(ETHTOOL_LINK_MODE_1000baseT_Half_BIT,
>> +			   phydev->supported);
>> +
>> +	phy_advertise_supported(phydev);
> 
> phy_remove_link_mode() would be better. The MAC driver then does not
> need to know about the insides of the phydev structure, and it
> implicitly handles this last part.
> 

Only small drawback is that it unnecessarily calls phy_advertise_supported()
after each statement. Therefore I decided against it.
But you're right, it's cleaner.

>     Andrew
> 

Heiner

> ---
> pw-bot: cr