netdev - Re: [PATCH net-next v3 0/4] Add support to do threaded napi busy poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b683298c-2110-410f-a073-4bfd60d49d02@uwaterloo.ca>
Date: Mon, 10 Feb 2025 21:52:28 -0500
From: Martin Karsten <mkarsten@...terloo.ca>
To: Samiullah Khawaja <skhawaja@...gle.com>, Joe Damato <jdamato@...tly.com>,
 Jakub Kicinski <kuba@...nel.org>, "David S . Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 almasrymina@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v3 0/4] Add support to do threaded napi busy poll

On 2025-02-06 17:06, Samiullah Khawaja wrote:
> On Thu, Feb 6, 2025 at 1:19 PM Joe Damato <jdamato@...tly.com> wrote:
>>
>> On Tue, Feb 04, 2025 at 07:18:36PM -0800, Joe Damato wrote:
>>> On Wed, Feb 05, 2025 at 12:10:48AM +0000, Samiullah Khawaja wrote:
>>>> Extend the already existing support of threaded napi poll to do continuous
>>>> busy polling.
>>>
>>> [...]
>>>
>>> Overall, +1 to everything Martin said in his response. I think I'd
>>> like to try to reproduce this myself to better understand the stated
>>> numbers below.
>>>
>>> IMHO: the cover letter needs more details.
>>>
>>>>
>>>> Setup:
>>>>
>>>> - Running on Google C3 VMs with idpf driver with following configurations.
>>>> - IRQ affinity and coalascing is common for both experiments.
>>>
>>> As Martin suggested, a lot more detail here would be helpful.
>>
>> Just to give you a sense of the questions I ran into while trying to
>> reproduce this just now:
>>
>> - What is the base SHA? You should use --base when using git
>>    format-patch. I assumed the latest net-next SHA and applied the
>>    patches to that.
> Yes that is true. I will use --base when I do it next. Thanks for the
> suggestion.

Sorry for replying to an older message. In trying to reproduce your 
setup it seems that onload from the github repo does not compile since 
the update to the kernel build system in kernel commit 13b2548. I am not 
that familiar with the details of either build system, so have filed an 
issue with onload. I was just wondering whether you had a workaround and 
could share it please?

Thanks,
Martin