netdev - Re: [PATCH net-next v2 0/2] Symmetric OR-XOR RSS hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250210162725.4bd38438@kernel.org>
Date: Mon, 10 Feb 2025 16:27:25 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Gal Pressman <gal@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, Jonathan Corbet <corbet@....net>, Tony Nguyen
 <anthony.l.nguyen@...el.com>, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>, Andrew Lunn <andrew+netdev@...n.ch>, Tariq
 Toukan <tariqt@...dia.com>, Edward Cree <ecree.xilinx@...il.com>, Ahmed
 Zaki <ahmed.zaki@...el.com>, linux-doc@...r.kernel.org
Subject: Re: [PATCH net-next v2 0/2] Symmetric OR-XOR RSS hash

On Sun, 9 Feb 2025 09:59:22 +0200 Gal Pressman wrote:
> I don't understand the rationale, the new input_xfrm field didn't
> deserve a selftest, why does a new value to the field does?

Ahmed and Sudheer added ETHTOOL_MSG_RSS_GET as part of their work.
Everyone pays off a little bit of technical debt to get their
feature in.

I don't appreciate your reaction. Please stop acting as if nVidia was 
a victim of some grand conspiracy within netdev.

> Testing this would require new userspace ethtool (which has not been
> submitted yet), I don't think it's wise to implement a test before the
> user interface/output is merged.

No it doesn't. You can call netlink directly from Python or C.

> I assume you want an additional case in rss_ctx.py?

No, separate test.