netdev - Re: [PATCH net-next, v8 2/2] selftests/net: Add selftest for IPv4 RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADXeF1GP24uJNYBPjjegs=sycUa1d=cVacvchKdAk5+p=ZOj8w@mail.gmail.com>
Date: Mon, 10 Feb 2025 21:43:03 -0800
From: Yuyang Huang <yuyanghuang@...gle.com>
To: Simon Horman <horms@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, 
	netdev@...r.kernel.org, Donald Hunter <donald.hunter@...il.com>, 
	Shuah Khan <shuah@...nel.org>, Nikolay Aleksandrov <razor@...ckwall.org>, 
	Hangbin Liu <liuhangbin@...il.com>, Daniel Borkmann <daniel@...earbox.net>, petrm@...dia.com, 
	linux-kselftest@...r.kernel.org, Maciej Żenczykowski <maze@...gle.com>, 
	Lorenzo Colitti <lorenzo@...gle.com>
Subject: Re: [PATCH net-next, v8 2/2] selftests/net: Add selftest for IPv4
 RTM_GETMULTICAST support

>FWIIW I think that the YAML spec entry is distinct from, although a
>dependency of, adding the test. I would put it in a separate patch.

Thanks for the feedback! I will split the change into two patches in
the next submission.

Thanks,

Yuyang


On Mon, Feb 10, 2025 at 8:13 AM Simon Horman <horms@...nel.org> wrote:
>
> On Fri, Feb 07, 2025 at 08:08:36PM +0900, Yuyang Huang wrote:
> > This change introduces a new selftest case to verify the functionality
> > of dumping IPv4 multicast addresses using the RTM_GETMULTICAST netlink
> > message. The test utilizes the ynl library to interact with the
> > netlink interface and validate that the kernel correctly reports the
> > joined IPv4 multicast addresses.
> >
> > To run the test, execute the following command:
> >
> > $ vng -v --user root --cpus 16 -- \
> >     make -C tools/testing/selftests TARGETS=net \
> >     TEST_PROGS=rtnetlink.py TEST_GEN_PROGS="" run_tests
> >
> > Cc: Maciej Żenczykowski <maze@...gle.com>
> > Cc: Lorenzo Colitti <lorenzo@...gle.com>
> > Signed-off-by: Yuyang Huang <yuyanghuang@...gle.com>
> > ---
> >
> > Changelog since v7:
> > - Create a new RtnlAddrFamily to load rt_addr.yaml.
> >
> > Changelog since v6:
> > - Move `getmaddrs` definition to rt_addr.yaml.
> >
> >  Documentation/netlink/specs/rt_addr.yaml      | 23 ++++++++++++++
>
> Hi Yuyang Huang,
>
> FWIIW I think that the YAML spec entry is distinct from, although a
> dependency of, adding the test. I would put it in a separate patch.
>
> >  tools/testing/selftests/net/Makefile          |  1 +
> >  .../testing/selftests/net/lib/py/__init__.py  |  2 +-
> >  tools/testing/selftests/net/lib/py/ynl.py     |  4 +++
> >  tools/testing/selftests/net/rtnetlink.py      | 30 +++++++++++++++++++
> >  5 files changed, 59 insertions(+), 1 deletion(-)
> >  create mode 100755 tools/testing/selftests/net/rtnetlink.py
>
> ...