netdev - Re: [PATCH] clk: bcm: rpi: Fix potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z6ro06dd81bGO77a@mev-dev.igk.intel.com>
Date: Tue, 11 Feb 2025 07:06:11 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Chenyuan Yang <chenyuan0y@...il.com>
Cc: mturquette@...libre.com, sboyd@...nel.org,
	florian.fainelli@...adcom.com,
	bcm-kernel-feedback-list@...adcom.com, richardcochran@...il.com,
	dave.stevenson@...pberrypi.com, popcornmix@...il.com,
	mripard@...nel.org, u.kleine-koenig@...libre.com, nathan@...nel.org,
	linux-clk@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, zzjas98@...il.com
Subject: Re: [PATCH] clk: bcm: rpi: Fix potential NULL pointer dereference

On Mon, Feb 10, 2025 at 06:09:17PM -0600, Chenyuan Yang wrote:
> The `init.name` could be NULL. Add missing check in the
> raspberrypi_clk_register().
> This is similar to commit 3027e7b15b02
> ("ice: Fix some null pointer dereference issues in ice_ptp.c").
> Besides, bcm2835_register_pll_divider() under the same directory also
> has a very similar check.
> 
> Signed-off-by: Chenyuan Yang <chenyuan0y@...il.com>
> ---
>  drivers/clk/bcm/clk-raspberrypi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-raspberrypi.c
> index 0e1fe3759530..720acc10f8aa 100644
> --- a/drivers/clk/bcm/clk-raspberrypi.c
> +++ b/drivers/clk/bcm/clk-raspberrypi.c
> @@ -286,6 +286,8 @@ static struct clk_hw *raspberrypi_clk_register(struct raspberrypi_clk *rpi,
>  	init.name = devm_kasprintf(rpi->dev, GFP_KERNEL,
>  				   "fw-clk-%s",
>  				   rpi_firmware_clk_names[id]);
> +	if (!init.name)
> +		return ERR_PTR(-ENOMEM);
>  	init.ops = &raspberrypi_firmware_clk_ops;
>  	init.flags = CLK_GET_RATE_NOCACHE;

Thanks for the fix. There is a need for a fixes tag in case like that.
Please add it in commit message. Take a look here for example [1].

[1] https://lore.kernel.org/netdev/DM3PR11MB8736BC7EF3A66720427F3775ECF22@DM3PR11MB8736.namprd11.prod.outlook.com/T/#mbc8028620ecffb2f3a23c96130fe03708e679b25

Beside that:
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>

>  
> -- 
> 2.34.1