netdev - Re: [PATCH] pinctrl: Fix potential NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6aa1ee3e-8310-450d-9165-7e33cc29f9ca@gmail.com>
Date: Wed, 12 Feb 2025 09:35:52 +0100
From: Matthias Brugger <matthias.bgg@...il.com>
To: Chenyuan Yang <chenyuan0y@...il.com>, geert+renesas@...der.be,
 linus.walleij@...aro.org, richardcochran@...il.com,
 angelogioacchino.delregno@...labora.com
Cc: linux-renesas-soc@...r.kernel.org, linux-gpio@...r.kernel.org,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org, zzjas98@...il.com
Subject: Re: [PATCH] pinctrl: Fix potential NULL pointer dereference



On 11/02/2025 00:25, Chenyuan Yang wrote:
> The `chip.label` could be NULL. Add missing check in the
> rza2_gpio_register().
> This is similar to commit 3027e7b15b02
> ("ice: Fix some null pointer dereference issues in ice_ptp.c").
> Besides, mediatek_gpio_bank_probe() in drivers/gpio/gpio-mt7621.c also
> has a very similar check.
> 
> Signed-off-by: Chenyuan Yang <chenyuan0y@...il.com>

Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>

> ---
>   drivers/pinctrl/renesas/pinctrl-rza2.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/pinctrl/renesas/pinctrl-rza2.c b/drivers/pinctrl/renesas/pinctrl-rza2.c
> index dd1f8c29d3e7..3da8b0d389c9 100644
> --- a/drivers/pinctrl/renesas/pinctrl-rza2.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rza2.c
> @@ -246,6 +246,9 @@ static int rza2_gpio_register(struct rza2_pinctrl_priv *priv)
>   	int ret;
>   
>   	chip.label = devm_kasprintf(priv->dev, GFP_KERNEL, "%pOFn", np);
> +	if (!chip.label)
> +		return -ENOMEM;
> +
>   	chip.parent = priv->dev;
>   	chip.ngpio = priv->npins;
>