netdev - RE: [EXTERNAL] Re: [net-next PATCH v5 5/6] octeontx2-pf: Prepare for AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SJ0PR18MB5216463921AF689670D461BBDBFC2@SJ0PR18MB5216.namprd18.prod.outlook.com>
Date: Wed, 12 Feb 2025 08:51:14 +0000
From: Suman Ghosh <sumang@...vell.com>
To: Simon Horman <horms@...nel.org>
CC: Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Geethasowjanya Akula
	<gakula@...vell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
        Hariprasad Kelam <hkelam@...vell.com>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linu Cherian
	<lcherian@...vell.com>, Jerin Jacob <jerinj@...vell.com>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        Bharat Bhushan
	<bbhushan2@...vell.com>,
        "hawk@...nel.org" <hawk@...nel.org>,
        "andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
        "ast@...nel.org"
	<ast@...nel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "larysa.zaremba@...el.com"
	<larysa.zaremba@...el.com>
Subject: RE: [EXTERNAL] Re: [net-next PATCH v5 5/6] octeontx2-pf: Prepare for
 AF_XDP

>> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
>> b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
>> index 44137160bdf6..b012d8794f18 100644
>> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
>> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
>> @@ -22,6 +22,12 @@
>>  #include "cn10k.h"
>>
>>  #define CQE_ADDR(CQ, idx) ((CQ)->cqe_base + ((CQ)->cqe_size * (idx)))
>> +#define READ_FREE_SQE(SQ, free_sqe)						   \
>> +	do {							                   \
>> +		typeof(SQ) _SQ = (SQ);						   \
>> +		free_sqe = (((_SQ)->cons_head - (_SQ)->head - 1 + (_SQ)-
>>sqe_cnt)  \
>> +			   & ((_SQ)->sqe_cnt - 1));
>\
>> +	} while (0)
>
>It looks like READ_FREE_SQE() could be a function rather than a macro.
>And, as an aside, CQE_ADDR could be too.
[Suman] I will address the READ_FREE_SQE, but CQE_ADDR will push a separate patch in net tree.
>
>>  #define PTP_PORT	        0x13F
>>  /* PTPv2 header Original Timestamp starts at byte offset 34 and
>>   * contains 6 byte seconds field and 4 byte nano seconds field.
>
>...