netdev - [ixgbe] Crash when running an XDP program

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <87mserpcl6.fsf@toke.dk>
Date: Wed, 12 Feb 2025 13:33:09 +0100
From: Toke Høiland-Jørgensen <toke@...hat.com>
To: Tony Nguyen <anthony.l.nguyen@...el.com>, Jacob Keller
 <jacob.e.keller@...el.com>, Maciej Fijalkowski
 <maciej.fijalkowski@...el.com>, Chandan Kumar Rout
 <chandanx.rout@...el.com>
Cc: Yue Haibing <yuehaibing@...wei.com>, Simon Horman <horms@...nel.org>,
 Samuel Dobron <sdobron@...hat.com>, netdev@...r.kernel.org,
 intel-wired-lan@...ts.osuosl.org
Subject: [ixgbe] Crash when running an XDP program

Hi folks,

Our LNST testing team uncovered a crash in ixgbe when running an XDP
program, see this report:
https://bugzilla.redhat.com/show_bug.cgi?id=2343204

>From looking at the code, it seems to me that the culprit is this commit:

c824125cbb18 ("ixgbe: Fix passing 0 to ERR_PTR in ixgbe_run_xdp()")

after that commit, the IS_ERR(skb) check in ixgbe_put_rx_buffer() no
longer triggers, and that function tries to dereference a NULL skb
pointer after an XDP program dropped the frame.

Could you please fix this?

And, erm, given the number of reviewed-by and tested-by tags in the
commit above, I'm guessing you don't have any XDP tests in your testing
regimen? Any chance you could add that? :)

Thanks!

-Toke