netdev - Re: [PATCH net-next v6 4/7] net: phy: marvell: Align set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f48fec27-e268-4102-9e48-159645084ce8@lunn.ch>
Date: Wed, 12 Feb 2025 02:53:37 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Gerhard Engleder <gerhard@...leder-embedded.com>
Cc: hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v6 4/7] net: phy: marvell: Align set_loopback()
 implementation

On Sun, Feb 09, 2025 at 08:08:24PM +0100, Gerhard Engleder wrote:
> Use genphy_loopback() to disable loopback like ksz9031_set_loopback().
> This way disable loopback is implemented only once within
> genphy_loopback() and the set_loopback() implementations look similar.
> 
> Also fix comment about msleep() in the out-of loopback case which is not
> executed in the out-of loopback case.
> 
> Suggested-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: Gerhard Engleder <gerhard@...leder-embedded.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew