netdev - Re: [PATCH net-next v6 5/7] tsnep: Select speed for loopback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b0e2b6e-fc26-4557-966d-48a985c6ccba@lunn.ch>
Date: Wed, 12 Feb 2025 02:55:47 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Gerhard Engleder <gerhard@...leder-embedded.com>
Cc: hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v6 5/7] tsnep: Select speed for loopback

On Sun, Feb 09, 2025 at 08:08:25PM +0100, Gerhard Engleder wrote:
> Use 100 Mbps only if the PHY is configured to this speed. Otherwise use
> always the maximum speed of 1000 Mbps.
> 
> Also remove explicit setting of carrier on and link mode after loopback.
> This is not needed anymore, because phy_loopback() with selected speed
> signals the link and the speed to the MAC.
> 
> Signed-off-by: Gerhard Engleder <gerhard@...leder-embedded.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew