netdev - Re: [PATCH net-next 5/5] eth: fbnic: re-sort the objects in the Makefile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8274ddab-51ca-40b3-84ec-29b2815048a6@intel.com>
Date: Wed, 12 Feb 2025 17:17:04 +0100
From: Alexander Lobakin <aleksander.lobakin@...el.com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Joe Damato <jdamato@...tly.com>, <davem@...emloft.net>,
	<alexanderduyck@...com>, <netdev@...r.kernel.org>, <edumazet@...gle.com>,
	<pabeni@...hat.com>, <andrew+netdev@...n.ch>, <horms@...nel.org>
Subject: Re: [PATCH net-next 5/5] eth: fbnic: re-sort the objects in the
 Makefile

From: Jakub Kicinski <kuba@...nel.org>
Date: Tue, 11 Feb 2025 14:32:34 -0800

> On Tue, 11 Feb 2025 11:54:37 -0800 Joe Damato wrote:
>> Incredibly minor nit, do you want to remove the trailing '\' after
>> fbnic_txrx.o which is the new last line to keep the format
>> consistent with how it was previously?
> 
> The point of having the comment is that the last real line can have the
> trailing \ and therefore will not need to be modified when an object is
> added after it :)

Nice idea :D

> 
> Thanks for the reviews!

Series:

Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>

Thanks,
Olek