netdev - Re: [PATCH net] s390/qeth: move netif_napi_add_tx() and napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z6z4CMhLo0aj5YEN@LQ3V64L9R2>
Date: Wed, 12 Feb 2025 11:35:36 -0800
From: Joe Damato <jdamato@...tly.com>
To: Alexandra Winter <wintera@...ux.ibm.com>
Cc: David Miller <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, netdev@...r.kernel.org,
	linux-s390@...r.kernel.org, Heiko Carstens <hca@...ux.ibm.com>,
	Vasily Gorbik <gor@...ux.ibm.com>,
	Alexander Gordeev <agordeev@...ux.ibm.com>,
	Christian Borntraeger <borntraeger@...ux.ibm.com>,
	Sven Schnelle <svens@...ux.ibm.com>,
	Thorsten Winkler <twinkler@...ux.ibm.com>,
	Simon Horman <horms@...nel.org>,
	Kuniyuki Iwashima <kuniyu@...zon.com>
Subject: Re: [PATCH net] s390/qeth: move netif_napi_add_tx() and
 napi_enable() from under BH

On Wed, Feb 12, 2025 at 05:36:59PM +0100, Alexandra Winter wrote:
> Like other drivers qeth is calling local_bh_enable() after napi_schedule()
> to kick-start softirqs [0].
> Since netif_napi_add_tx() and napi_enable() now take the netdev_lock()
> mutex [1], move them out from under the BH protection. Same solution as in
> commit a60558644e20 ("wifi: mt76: move napi_enable() from under BH")
> 
> Fixes: 1b23cdbd2bbc ("net: protect netdev->napi_list with netdev_lock()")

Hm, I wonder if the fixes should be for commit 413f0271f396 ("net:
protect NAPI enablement with netdev_lock()") instead ?

> Link: https://lore.kernel.org/netdev/20240612181900.4d9d18d0@kernel.org/ [0]
> Link: https://lore.kernel.org/netdev/20250115035319.559603-1-kuba@kernel.org/ [1]
> Signed-off-by: Alexandra Winter <wintera@...ux.ibm.com>
> ---
>  drivers/s390/net/qeth_core_main.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Other than the above, I briefly scanned the driver source and the
change seems reasonable.

I am not sure whether a different Fixes is needed or not (I'll leave
that to the maintainers to decide), but whether this is fine as is
or is re-posted with a new Fixes tag:

Acked-by: Joe Damato <jdamato@...tly.com>