netdev - Re: [PATCH net-next v2 0/7] net: deduplicate cookie logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5281a36d-e46d-44d0-80ac-9a65d8201863@kernel.org>
Date: Wed, 12 Feb 2025 13:11:22 -0700
From: David Ahern <dsahern@...nel.org>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>, netdev@...r.kernel.org
Cc: davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com,
 pabeni@...hat.com, horms@...nel.org, Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next v2 0/7] net: deduplicate cookie logic

On 2/11/25 7:09 PM, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@...gle.com>
> 
> Reuse standard sk, ip and ipv6 cookie init handlers where possible.
> 
> Avoid repeated open coding of the same logic.
> Harmonize feature sets across protocols.
> Make IPv4 and IPv6 logic more alike.
> Simplify adding future new fields with a single init point.
> 
> v1->v2:
>   - limit INET_DSCP_MASK to routing
>   - remove no longer used local variable (fix build warning)
> 
> Willem de Bruijn (7):
>   tcp: only initialize sockcm tsflags field
>   net: initialize mark in sockcm_init
>   ipv4: initialize inet socket cookies with sockcm_init
>   ipv4: remove get_rttos
>   icmp: reflect tos through ip cookie rather than updating inet_sk
>   ipv6: replace ipcm6_init calls with ipcm6_init_sk
>   ipv6: initialize inet socket cookies with sockcm_init
> 
>  include/net/ip.h       | 16 +++++-----------
>  include/net/ipv6.h     | 11 ++---------
>  include/net/sock.h     |  1 +
>  net/can/raw.c          |  2 +-
>  net/ipv4/icmp.c        |  6 ++----
>  net/ipv4/ping.c        |  6 +++---
>  net/ipv4/raw.c         |  6 +++---
>  net/ipv4/tcp.c         |  2 +-
>  net/ipv4/udp.c         |  6 +++---
>  net/ipv6/ping.c        |  3 ---
>  net/ipv6/raw.c         | 15 +++------------
>  net/ipv6/udp.c         | 10 +---------
>  net/l2tp/l2tp_ip6.c    |  8 +-------
>  net/packet/af_packet.c |  9 ++++-----
>  14 files changed, 30 insertions(+), 71 deletions(-)
> 

LGTM. For the set

Reviewed-by: David Ahern <dsahern@...nel.org>