netdev - Re: [PATCH v7 3/7] i2c: Add Nuvoton NCT6694 I2C support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOoeyxUsoqtieRQVYr4DWPKOV4kTgcib1c3-tbz7KayTnshaig@mail.gmail.com>
Date: Wed, 12 Feb 2025 10:25:17 +0800
From: Ming Yu <a0282524688@...il.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: tmyu0@...oton.com, lee@...nel.org, linus.walleij@...aro.org, brgl@...ev.pl, 
	andi.shyti@...nel.org, mkl@...gutronix.de, mailhol.vincent@...adoo.fr, 
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, wim@...ux-watchdog.org, 
	linux@...ck-us.net, jdelvare@...e.com, alexandre.belloni@...tlin.com, 
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org, 
	linux-i2c@...r.kernel.org, linux-can@...r.kernel.org, netdev@...r.kernel.org, 
	linux-watchdog@...r.kernel.org, linux-hwmon@...r.kernel.org, 
	linux-rtc@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v7 3/7] i2c: Add Nuvoton NCT6694 I2C support

Dear Christophe,

Thank you for reviewing,

Christophe JAILLET <christophe.jaillet@...adoo.fr> 於 2025年2月8日 週六 上午3:06寫道：
>
> Le 07/02/2025 à 08:44, Ming Yu a écrit :
> > This driver supports I2C adapter functionality for NCT6694 MFD
> > device based on USB interface, each I2C controller use default
> > baudrate(100K).
>
> ...
>
> > +static int nct6694_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
> > +{
> > +     struct nct6694_i2c_data *data = adap->algo_data;
> > +     struct nct6694_i2c_deliver *deliver = &data->deliver;
> > +     static const struct nct6694_cmd_header cmd_hd = {
> > +             .mod = NCT6694_I2C_MOD,
> > +             .cmd = NCT6694_I2C_DELIVER,
> > +             .sel = NCT6694_I2C_DELIVER_SEL,
> > +             .len = cpu_to_le16(sizeof(*deliver))
> > +     };
> > +     int ret, i;
> > +
> > +     for (i = 0; i < num ; i++) {
>
> Tiny tiny nitpick: unneeded extra space after num
>
Okay, I will fix it in the next patch.


Best regards,
Ming