netdev - Re: [PATCH 2/9] net: bcmasp: Add missing of_node_get() before of_find_node_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cb2db0c4-6f3a-4d44-90e5-b37cbe5e66fb@kernel.org>
Date: Wed, 12 Feb 2025 06:52:46 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Zhang Zekun <zhangzekun11@...wei.com>, robh@...nel.org,
 saravanak@...gle.com, justin.chen@...adcom.com,
 florian.fainelli@...adcom.com, andrew+netdev@...n.ch, kuba@...nel.org,
 o.rempel@...gutronix.de, kory.maincent@...tlin.com,
 jacopo+renesas@...ndi.org, kieran.bingham+renesas@...asonboard.com,
 laurent.pinchart+renesas@...asonboard.com, maddy@...ux.ibm.com,
 mpe@...erman.id.au, npiggin@...il.com, olteanv@...il.com,
 davem@...emloft.net, taras.chornyi@...ision.eu, edumazet@...gle.com,
 pabeni@...hat.com, sudeep.holla@....com, cristian.marussi@....com
Cc: arm-scmi@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
 linux-media@...r.kernel.org, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, chenjun102@...wei.com
Subject: Re: [PATCH 2/9] net: bcmasp: Add missing of_node_get() before
 of_find_node_by_name()

On 07/02/2025 02:31, Zhang Zekun wrote:
> of_find_node_by_name() will decrease the refcount of the device_node.
> So, get the device_node before passing to it.
> 
> Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Zhang Zekun <zhangzekun11@...wei.com>
> ---
>  drivers/net/ethernet/broadcom/asp2/bcmasp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> index a68fab1b05f0..093c8ea72af9 100644
> --- a/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp.c
> @@ -1367,7 +1367,7 @@ static int bcmasp_probe(struct platform_device *pdev)
>  	bcmasp_core_init(priv);
>  	bcmasp_core_init_filters(priv);
>  
> -	ports_node = of_find_node_by_name(dev->of_node, "ethernet-ports");
> +	ports_node = of_find_node_by_name_balanced(dev->of_node, "ethernet-ports");

Why this cannot be of_get_child_by_name()?

Best regards,
Krzysztof