netdev - Re: [PATCH v2 net-next] page_pool: avoid infinite loop to schedule delayed worker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94376281-1922-40ee-bfd6-80ff88b9eed7@redhat.com>
Date: Thu, 13 Feb 2025 09:32:11 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Jason Xing <kerneljasonxing@...il.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, ilias.apalodimas@...aro.org,
 edumazet@...gle.com, kuba@...nel.org, horms@...nel.org, hawk@...nel.org,
 almasrymina@...gle.com
Subject: Re: [PATCH v2 net-next] page_pool: avoid infinite loop to schedule
 delayed worker

On 2/13/25 6:21 AM, Jason Xing wrote:
> diff --git a/net/core/page_pool.c b/net/core/page_pool.c
> index 1c6fec08bc43..e1f89a19a6b6 100644
> --- a/net/core/page_pool.c
> +++ b/net/core/page_pool.c
> @@ -1112,13 +1112,12 @@ static void page_pool_release_retry(struct work_struct *wq)
>  	int inflight;
>  
>  	inflight = page_pool_release(pool);
> -	if (!inflight)
> -		return;
>  
>  	/* Periodic warning for page pools the user can't see */
>  	netdev = READ_ONCE(pool->slow.netdev);

This causes UaF, as catched by the CI:

https://netdev-3.bots.linux.dev/vmksft-net-dbg/results/990441/34-udpgro-bench-sh/stderr

at this point 'inflight' could be 0 and 'pool' already freed.

/P