netdev - Re: [PATCH net-next v2] net: ethernet: mediatek: add EEE support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z623GQHI_FHyDyjE@shell.armlinux.org.uk>
Date: Thu, 13 Feb 2025 09:10:49 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Paolo Abeni <pabeni@...hat.com>
Cc: Felix Fietkau <nbd@....name>, Sean Wang <sean.wang@...iatek.com>,
	Lorenzo Bianconi <lorenzo@...nel.org>,
	linux-mediatek@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	Jakub Kicinski <kuba@...nel.org>, Qingfang Deng <dqfext@...il.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next v2] net: ethernet: mediatek: add EEE support

On Thu, Feb 13, 2025 at 10:04:50AM +0100, Paolo Abeni wrote:
> On 2/10/25 1:52 PM, Qingfang Deng wrote:
> > Add EEE support to MediaTek SoC Ethernet. The register fields are
> > similar to the ones in MT7531, except that the LPI threshold is in
> > milliseconds.
> > 
> > Signed-off-by: Qingfang Deng <dqfext@...il.com>
> 
> @Felix, @Sean, @Lorenzo: could you please have a look?

That would be a waste of time, because it's implementing the "old way"
including using phy_init_eee() which Andrew wants to get rid of. It
should be using phylink's EEE management.

The patches for the mt753x driver converting that over have now been
apparently merged last night according to patchwork into net-next, but
something's gone wrong because there's no updates to the git trees
on korg,

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!