netdev - Re: [PATCH net-next 1/4] net/mlx5: Apply rate-limiting to high temperature warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f1fe6175-c00b-4ba4-9091-84b09a0acdde@intel.com>
Date: Thu, 13 Feb 2025 11:15:43 +0100
From: Mateusz Polchlopek <mateusz.polchlopek@...el.com>
To: Tariq Toukan <tariqt@...dia.com>, "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Eric
 Dumazet" <edumazet@...gle.com>, Andrew Lunn <andrew+netdev@...n.ch>
CC: Shahar Shitrit <shshitrit@...dia.com>, Gal Pressman <gal@...dia.com>,
	Saeed Mahameed <saeedm@...dia.com>, Leon Romanovsky <leon@...nel.org>,
	<netdev@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next 1/4] net/mlx5: Apply rate-limiting to high
 temperature warning



On 2/13/2025 10:46 AM, Tariq Toukan wrote:
> From: Shahar Shitrit <shshitrit@...dia.com>
> 
> Wrap the high temperature warning in a temperature event with
> a call to net_ratelimit() to prevent flooding the kernel log
> with repeated warning messages when temperature exceeds the
> threshold multiple times within a short duration.
> 
> Signed-off-by: Shahar Shitrit <shshitrit@...dia.com>
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/events.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/events.c b/drivers/net/ethernet/mellanox/mlx5/core/events.c
> index d91ea53eb394..e8beb6289d01 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/events.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/events.c
> @@ -165,9 +165,10 @@ static int temp_warn(struct notifier_block *nb, unsigned long type, void *data)
>   	value_lsb = be64_to_cpu(eqe->data.temp_warning.sensor_warning_lsb);
>   	value_msb = be64_to_cpu(eqe->data.temp_warning.sensor_warning_msb);
>   
> -	mlx5_core_warn(events->dev,
> -		       "High temperature on sensors with bit set %llx %llx",
> -		       value_msb, value_lsb);
> +	if (net_ratelimit())
> +		mlx5_core_warn(events->dev,
> +			       "High temperature on sensors with bit set %llx %llx",
> +			       value_msb, value_lsb);
>   
>   	return NOTIFY_OK;
>   }

Nice improvement, thanks
Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@...el.com>