netdev - Re: [PATCH net-next v2] selftests: net: Add support for testing SO_RCVMARK and SO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKm6_Rv4LCpy6KaV84gOi7wW7OKdasbx2zqfFwFG26=L6rkhgA@mail.gmail.com>
Date: Thu, 13 Feb 2025 13:46:33 +0100
From: Anna Nyiri <annaemesenyiri@...il.com>
To: Paolo Abeni <pabeni@...hat.com>
Cc: netdev@...r.kernel.org, fejes@....elte.hu, edumazet@...gle.com, 
	kuba@...nel.org, willemb@...gle.com, idosch@...sch.org, horms@...nel.org, 
	davem@...emloft.net, shuah@...nel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next v2] selftests: net: Add support for testing
 SO_RCVMARK and SO_RCVPRIORITY

Paolo Abeni <pabeni@...hat.com> ezt írta (időpont: 2025. febr. 11., K, 12:19):
>
> On 2/10/25 8:22 PM, Anna Emese Nyiri wrote:
> > Introduce tests to verify the correct functionality of the SO_RCVMARK and
> > SO_RCVPRIORITY socket options.
> >
> > Key changes include:
> >
> > - so_rcv_listener.c: Implements a receiver application to test the correct
> > behavior of the SO_RCVMARK and SO_RCVPRIORITY options.
> > - test_so_rcv.sh: Provides a shell script to automate testing for these options.
> > - Makefile: Integrates test_so_rcv.sh into the kernel selftests.
> >
> > v2:
> >
> > - Add the C part to TEST_GEN_PROGS and .gitignore.
> > - Modify buffer space and add IPv6 testing option
> > in so_rcv_listener.c.
> > - Add IPv6 testing, remove unnecessary comment,
> > add kselftest exit codes, run both binaries in a namespace,
> > and add sleep in test_so_rcv.sh.
> > The sleep was added to ensure that the listener process has
> > enough time to start before the sender attempts to connect.
> > - Rebased on net-next.
> >
> > v1:
> >
> > https://lore.kernel.org/netdev/20250129143601.16035-2-annaemesenyiri@gmail.com/
>
> Unfortunately the added self-test does not run successfully in the CI:

I think the test is not running because it is added to TEST_GEN_PROGS.
However, after reconsidering, I'm not sure it should be there, since
this test does not run on its own but is executed by the
test_so_rcv.sh shell script.
Wouldn't it be more appropriate to add so_rcv_listener to
TEST_GEN_FILES instead?

> https://netdev-3.bots.linux.dev/vmksft-net/results/987742/117-so-rcv-listener/stdout

> Please have a look at:
>
> https://github.com/linux-netdev/nipa/wiki/How-to-run-netdev-selftests-CI-style
>
> to test the change locally in a CI-like way.
>
> Cheers,
>
> Paolo
>