netdev - Re: [PATCH net-next 1/3] r8169: add PHY c45 ops for MDIO_MMD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <40a4262e-1398-4b59-bba5-24276fcc8fab@lunn.ch>
Date: Thu, 13 Feb 2025 14:19:35 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Realtek linux nic maintainers <nic_swsd@...ltek.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	Paolo Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>,
	David Miller <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Simon Horman <horms@...nel.org>,
	Russell King - ARM Linux <linux@...linux.org.uk>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 1/3] r8169: add PHY c45 ops for MDIO_MMD_VEND2
 registers

> +static int r8169_mdio_write_reg_c45(struct mii_bus *mii_bus, int addr,
> +				    int devnum, int regnum, u16 val)
> +{
> +	struct rtl8169_private *tp = mii_bus->priv;
> +
> +	if (addr > 0)
> +		return -ENODEV;
> +
> +	if (devnum == MDIO_MMD_VEND2 && regnum > MDIO_STAT2 )
> +		r8168_phy_ocp_write(tp, regnum, val);
> +
> +	return 0;

We don't expect writes to random registers. So returning EIO or ENODEV
for MMD other than VEND2 might help find bugs. Also, it seems like a
write to regnum <= MDIO_STAT2 would be a bug, since those registers
don't exist?

	Andrew