netdev - Re: [PATCH net-next 1/3] net: phy: mediatek: Add token ring access helper functions in mtk-phy-lib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z633GUUhyxinwWiP@makrotopia.org>
Date: Thu, 13 Feb 2025 13:43:53 +0000
From: Daniel Golle <daniel@...rotopia.org>
To: Andrew Lunn <andrew@...n.ch>
Cc: SkyLake Huang (黃啟澤) <SkyLake.Huang@...iatek.com>,
	"dqfext@...il.com" <dqfext@...il.com>,
	Steven Liu (劉人豪) <steven.liu@...iatek.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"linux@...linux.org.uk" <linux@...linux.org.uk>,
	"hkallweit1@...il.com" <hkallweit1@...il.com>,
	"horms@...nel.org" <horms@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>
Subject: Re: [PATCH net-next 1/3] net: phy: mediatek: Add token ring access
 helper functions in mtk-phy-lib

On Thu, Feb 13, 2025 at 02:29:35PM +0100, Andrew Lunn wrote:
> On Thu, Feb 13, 2025 at 07:39:39AM +0000, SkyLake Huang (黃啟澤) wrote:
> > On Sun, 2025-01-19 at 18:12 +0100, Andrew Lunn wrote:
> > > 
> > > External email : Please do not click links or open attachments until
> > > you have verified the sender or the content.
> > > 
> > > 
> > > > +/* ch_addr = 0x1, node_addr = 0xf, data_addr = 0x1 */
> > > > +/* MrvlTrFix100Kp */
> > > > +#define MRVL_TR_FIX_100KP_MASK                       GENMASK(22,
> > > > 20)
> > > > +/* MrvlTrFix100Kf */
> > > > +#define MRVL_TR_FIX_100KF_MASK                       GENMASK(19,
> > > > 17)
> > > > +/* MrvlTrFix1000Kp */
> > > > +#define MRVL_TR_FIX_1000KP_MASK                      GENMASK(16,
> > > > 14)
> > > > +/* MrvlTrFix1000Kf */
> > > > +#define MRVL_TR_FIX_1000KF_MASK                      GENMASK(13,
> > > > 11)
> > > 
> > > What does the Mrvl prefix stand for?
> > > 
> > > This patch is pretty much impossible to review because it makes so
> > > many changes. Please split it up into lots of small simple changes.
> > > 
> > >     Andrew
> > > 
> > > ---
> > > pw-bot: cr
> > Those registers with Mrvl* prefix were originally designed for
> > connection with certain Marvell devices. It's our DSP parameters.
> 
> Will this code work with real Marvell devices? Is this PHY actually
> licensed from Marvell?

>From what I understood the tuning of those parameters is required
to connect to a Marvell PHY link partner on the other end.