netdev - Re: [PATCH net-next] eth: fbnic: Add ethtool support for IRQ coalescing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <089b8fb8-5eb7-455b-ab3d-5301f9058ea5@lunn.ch>
Date: Thu, 13 Feb 2025 15:00:00 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Mohsin Bashir <mohsin.bashr@...il.com>
Cc: netdev@...r.kernel.org, alexanderduyck@...com, kuba@...nel.org,
	andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	pabeni@...hat.com, linux@...linux.org.uk, sanman.p211993@...il.com,
	vadim.fedorenko@...ux.dev, suhui@...china.com, horms@...nel.org,
	sdf@...ichev.me, jdamato@...tly.com, brett.creeley@....com,
	przemyslaw.kitszel@...el.com, kernel-team@...a.com
Subject: Re: [PATCH net-next] eth: fbnic: Add ethtool support for IRQ
 coalescing

> +static int fbnic_set_coalesce(struct net_device *netdev,
> +			      struct ethtool_coalesce *ec,
> +			      struct kernel_ethtool_coalesce *kernel_coal,
> +			      struct netlink_ext_ack *extack)
> +{
> +	struct fbnic_net *fbn = netdev_priv(netdev);
> +
> +	/* Verify against hardware limits */
> +	if (ec->rx_coalesce_usecs >
> +	    FIELD_MAX(FBNIC_INTR_CQ_REARM_RCQ_TIMEOUT) ||
> +	    ec->tx_coalesce_usecs >
> +	    FIELD_MAX(FBNIC_INTR_CQ_REARM_TCQ_TIMEOUT) ||
> +	    ec->rx_max_coalesced_frames * FBNIC_MIN_RXD_PER_FRAME >
> +	    FIELD_MAX(FBNIC_QUEUE_RIM_THRESHOLD_RCD_MASK))
> +		return -EINVAL;

You have an extack here, so you could give an indication which
parameter is out of range?

	Andrew