netdev - Re: [PATCH v2 0/3] prandom: remove next_pseudo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <sac7e53vnz4djrkpjwvwrr5j54zf3h2tpl4jle6f2djipesyxv@sybj4jr37j5v>
Date: Thu, 13 Feb 2025 14:27:40 +0000
From: Krzysztof Karas <krzysztof.karas@...el.com>
To: Markus Theil <theil.markus@...il.com>
CC: <linux-kernel@...r.kernel.org>, <intel-gfx@...ts.freedesktop.org>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH v2 0/3] prandom: remove next_pseudo_random32

Hi Markus,

> next_pseudo_random32 implements a LCG with known bad statistical
> properties and is only used in two pieces of testing code. Remove and
> convert the remaining two users to the single PRNG interface in
> prandom.h
> 
> This removes another option of using an insecure PRNG.
> 
> Markus Theil (3):
>   drm/i915/selftests: use prandom in selftest
>   media: vivid: use prandom
>   prandom: remove next_pseudo_random32
> 
>  drivers/gpu/drm/i915/selftests/i915_gem.c        | 7 ++++---
>  drivers/media/test-drivers/vivid/vivid-vid-cap.c | 4 +++-
>  include/linux/prandom.h                          | 6 ------
>  3 files changed, 7 insertions(+), 10 deletions(-)
>

The series looks good:
Reviewed-by: Krzysztof Karas <krzysztof.karas@...el.com>
on all the patches.

Best Regards,
Krzysztof