netdev - Re: [PATCH 10/12] bluetooth: hci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8e954934-b0af-4c80-9ca0-1914b65644f3@bootlin.com>
Date: Thu, 13 Feb 2025 16:30:48 +0100
From: Alexis Lothoré <alexis.lothore@...tlin.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Marcel Holtmann <marcel@...tmann.org>,
 Luiz Augusto von Dentz <luiz.dentz@...il.com>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Ajay Singh <ajay.kathat@...rochip.com>,
 Claudiu Beznea <claudiu.beznea@...on.dev>, Kalle Valo <kvalo@...nel.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, Nicolas Ferre
 <nicolas.ferre@...rochip.com>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Marek Vasut <marex@...x.de>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>, linux-bluetooth@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 10/12] bluetooth: hci_wilc: add wilc hci driver

Hi Krzysztof,

On 2/13/25 10:24, Krzysztof Kozlowski wrote:
> On Wed, Feb 12, 2025 at 04:46:29PM +0100, Alexis Lothoré wrote:
>> +#include "linux/bitops.h"
>> +#include "linux/byteorder/generic.h"
>> +#include "linux/err.h"
>> +#include "linux/gfp_types.h"
>> +#include "net/bluetooth/bluetooth.h"
>> +#include "net/bluetooth/hci.h"
> 
> Keep some order here. Why some are <> some "", why net is mixed with
> linux...

[...]

>> +	wilc_adapter = kzalloc(sizeof(*wilc_adapter), GFP_KERNEL);
> 
> Why not devm?

[...]

>> +	if (IS_ERR(wlan)) {
>> +		pr_warn("Can not initialize bluetooth: %pe\n", wlan);
> 
> dev_warn or even dev_err_probe to handle deferral.

[...]

>> +	dev_info(&serdev->dev, "WILC hci interface registered");
> 
> Drop simple probe statuses. sysfs already provides this.

[...]

>> +static struct serdev_device_driver wilc_bt_serdev_driver = {
>> +	.probe = wilc_bt_serdev_probe,
>> +	.remove = wilc_bt_serdev_remove,
>> +	.driver = {
>> +		.name = "hci_uart_wilc",
>> +		.of_match_table = of_match_ptr(wilc_bt_of_match),
> 
> Drop of_match_tr, you have warnings here.

Thanks for the review, true for all raised points, which will be handled in next
rev.

Alexis
> 
> Best regards,
> Krzysztof
> 

-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com